-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update connector packaging to support Inline Binary definitions #182
Merged
codingkarthik
merged 55 commits into
main
from
kc/update-connector-packaging-definition
Jan 24, 2025
Merged
Update connector packaging to support Inline Binary definitions #182
codingkarthik
merged 55 commits into
main
from
kc/update-connector-packaging-definition
Jan 24, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-Bilal
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rubberstamp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update connector packaging to support multi-platform CLI binaries
This PR updates our GitHub Actions workflow to support building and packaging CLI binaries for multiple platforms while following the latest connector packaging specification. The changes introduce a more robust approach to creating platform-specific CLI binaries and generating the corresponding metadata for the Hasura CLI plugin system.
Key Changes
Multi-Platform Binary Support
The build workflow now creates platform-specific binaries for:
Enhanced Build and Packaging Process
Each binary is properly named and packaged following Hasura's conventions, with SHA256 checksums generated for verification. The binaries are combined into a single tarball (cli.tar.gz) that gets attached to GitHub releases.
Updated CLI Initialization
The CLI initialization command has been enhanced to support the new binary CLI manifest format. This manifest contains platform-specific information including download URLs, SHA256 checksums, and binary paths. When initializing a new connector configuration, the CLI can now embed this manifest into the connector metadata, enabling the Hasura CLI to automatically download and use the correct binary for the user's platform.
Modernized Metadata Generation
The connector metadata generation has been updated to align with the latest specification from the packaging RFC. Notable changes include:
Impact
These changes make our connector more portable across different platforms while maintaining security through checksum verification. The updated metadata format provides better integration with the Hasura ecosystem and improved user experience through platform-specific binary selection.
Testing
Related